Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdevelop, kdev-php, kdev-python: 5.4.2 -> 5.4.3 #71603

Merged
merged 1 commit into from
Nov 6, 2019
Merged

kdevelop, kdev-php, kdev-python: 5.4.2 -> 5.4.3 #71603

merged 1 commit into from
Nov 6, 2019
+7 −6

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 22, 2019 •
edited by jonringer
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@aanderse
kdevelop, kdev-php, kdev-python: 5.4.2 -> 5.4.3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
922b4f7
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 22, 2019
jonringer
jonringer approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
kdevelop gui launches fine

[7 built (1 failed), 13 copied (913.5 MiB), 158.7 MiB DL]
error: build of '/nix/store/vx081nr5z72696fclczrl3hv9c6y9sw6-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71603
4 package were build:
kdev-php kdev-python kdevelop kdevelop-unwrapped

I did see this, not sure if normal:

kf5.kdbusaddons: Can not find 'kdeinit5' executable at  .... # my $PATH

@aanderse
Copy link
Member Author

aanderse commented Nov 6, 2019

I'm fairly certain that error was already there. I should look into that at some point...

Thanks @jonringer!

@aanderse aanderse merged commit ec65794 into NixOS:master Nov 6, 2019
@aanderse aanderse deleted the kdevelop branch November 6, 2019 03:11
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@aanderse @dtzWill
Merge pull request NixOS#71603 from aanderse/kdevelop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4d9b646 
kdevelop, kdev-php, kdev-python: 5.4.2 -> 5.4.3

(cherry picked from commit ec65794)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @jonringer