youtube-dl: 2019.10.16 -> 2019.10.22 #71602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
requested review from
AndersonTorres,
bluescreen303,
fpletz,
Fuuzetsu and
Phreedom
It would certainly be preferable to have a dedicated pull request for the backport as it should be properly tested as well. |
|
Running youtube-dl from the build results of nix-review leaves me with this error. [nix-shell:~/.cache/nix-review/pr-71602-2]$ youtube-dl
Traceback (most recent call last):
File "/nix/store/mnr7ix39r93m1bw75dkzz0naa72chz0v-python3.7-youtube-dl-2019.10.22/bin/.youtube-dl-wrapped", line 7, in <module>
from youtube_dl import main
File "/nix/store/v8xb6ldqq128yafpv2m6j8xdx2dmpq5v-python3.8-youtube-dl-2019.10.22/lib/python3.8/site-packages/youtube_dl/__init__.py", line 15, in <module>
from .options import (
File "/nix/store/v8xb6ldqq128yafpv2m6j8xdx2dmpq5v-python3.8-youtube-dl-2019.10.22/lib/python3.8/site-packages/youtube_dl/options.py", line 8, in <module>
from .downloader.external import list_external_downloaders
File "/nix/store/v8xb6ldqq128yafpv2m6j8xdx2dmpq5v-python3.8-youtube-dl-2019.10.22/lib/python3.8/site-packages/youtube_dl/downloader/__init__.py", line 5, in <module>
from .hls import HlsFD
File "/nix/store/v8xb6ldqq128yafpv2m6j8xdx2dmpq5v-python3.8-youtube-dl-2019.10.22/lib/python3.8/site-packages/youtube_dl/downloader/hls.py", line 6, in <module>
from Crypto.Cipher import AES
File "/nix/store/knl6l75h1agddyixkjvnkmp89fkniq4g-python3.8-pycryptodome-3.7.3/lib/python3.8/site-packages/Crypto/Cipher/__init__.py", line 27, in <module>
from Crypto.Cipher._mode_ecb import _create_ecb_cipher
File "/nix/store/knl6l75h1agddyixkjvnkmp89fkniq4g-python3.8-pycryptodome-3.7.3/lib/python3.8/site-packages/Crypto/Cipher/_mode_ecb.py", line 47, in <module>
"""
File "/nix/store/knl6l75h1agddyixkjvnkmp89fkniq4g-python3.8-pycryptodome-3.7.3/lib/python3.8/site-packages/Crypto/Util/_raw_api.py", line 299, in load_pycryptodome_raw_lib
raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.cpython-37m-x86_64-linux-gnu.so': /nix/store/knl6l75h1agddyixkjvnkmp89fkniq4g-python3.8-pycryptodome-3.7.3/lib/python3.8/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-37m-x86_64-linux-gnu.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.abi3.so': /nix/store/knl6l75h1agddyixkjvnkmp89fkniq4g-python3.8-pycryptodome-3.7.3/lib/python3.8/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.so': /nix/store/knl6l75h1agddyixkjvnkmp89fkniq4g-python3.8-pycryptodome-3.7.3/lib/python3.8/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory |
fpletz
approved these changes
Oct 26, 2019
|
@worldofpeace Could you review this PR? I think it is ready to be merged. Thank you! |
|
Notice to reviewers: I don't think you can properly test python applications in nix-review because the nix shell environment it creates will mix python versions breaking the program at runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
youtube-dlto the latest release.NOTE: Updates to
youtube-dlshould be backported, thanks!Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @bluescreen303 @Phreedom @AndersonTorres @Fuuzetsu @fpletz @Enzime