Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MouseEvent's x/y and offsetX/offsetY attributes #24521

Merged
merged 1 commit into from Nov 5, 2019
Merged

Implement MouseEvent's x/y and offsetX/offsetY attributes #24521

merged 1 commit into from Nov 5, 2019

Conversation

tigleym
Copy link

@tigleym tigleym commented Oct 22, 2019

Implement MouseEvent's x/y and offsetX/offsetY attributes

  • There are tests for these changes OR
  • These changes do not require tests because ___

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @asajeffrey (or someone else) soon.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/MouseEvent.webidl, components/script/dom/domrect.rs, components/script/dom/mouseevent.rs
  • @KiChjang: components/script/dom/webidls/MouseEvent.webidl, components/script/dom/domrect.rs, components/script/dom/mouseevent.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 22, 2019
@servo-wpt-sync servo-wpt-sync mentioned this pull request Oct 22, 2019
Merged
@servo-wpt-sync
Copy link
Collaborator

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19816.

@jdm
Copy link
Member

jdm commented Oct 22, 2019

@bors-servo try=wpt

@bors-servo
Copy link
Contributor

⌛ Trying commit b336735 with merge b3119be...

bors-servo pushed a commit that referenced this pull request Oct 22, 2019
Auto merge of #24521 - tigleym:missing_cssom_attributes, r=<try>
b3119be 
Implement MouseEvent's x/y and offsetX/offsetY attributes

<!-- Please describe your changes on the following line: -->
Implement MouseEvent's x/y and offsetX/offsetY attributes

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #24248 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True

atouchet
atouchet reviewed Oct 23, 2019
View reviewed changes
tests/wpt/metadata/css/cssom-view/mouseEvent.html.ini
@@ -1,4 +1 @@
[mouseEvent.html]
[MouseEvent's x and y must be equal to clientX and clientY.]
expected: FAIL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no more failing tests you can delete the file.

@servo-wpt-sync
Copy link
Collaborator

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19816.

@jdm jdm assigned jdm and unassigned asajeffrey Oct 24, 2019
jdm
jdm requested changes Oct 25, 2019
View reviewed changes
components/script/dom/mouseevent.rs Outdated Show resolved Hide resolved
components/script/dom/mouseevent.rs Outdated Show resolved Hide resolved
components/script/dom/domrect.rs Outdated Show resolved Hide resolved
@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 25, 2019
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Oct 29, 2019
@servo-wpt-sync
Copy link
Collaborator

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19816.

@jdm
Copy link
Member

jdm commented Nov 4, 2019

This looks good, it just needs a final ./mach update-manifest to reflect the changes to the WPT test.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 4, 2019
@tigleym
Copy link
Author

tigleym commented Nov 4, 2019

This looks good, it just needs a final ./mach update-manifest to reflect the changes to the WPT test.

Sounds good! I'll get this updated today.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 4, 2019
@servo-wpt-sync
Copy link
Collaborator

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#19816.

@jdm
Copy link
Member

jdm commented Nov 5, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 38b91c3 has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 5, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 38b91c3 with merge f6a906d...

bors-servo pushed a commit that referenced this pull request Nov 5, 2019
Auto merge of #24521 - tigleym:missing_cssom_attributes, r=jdm
f6a906d 
Implement MouseEvent's x/y and offsetX/offsetY attributes

<!-- Please describe your changes on the following line: -->
Implement MouseEvent's x/y and offsetX/offsetY attributes

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #24248 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

⛄ The build was interrupted to prioritize another pull request.

@bors-servo
Copy link
Contributor

⌛ Testing commit 38b91c3 with merge 28dbbda...

bors-servo pushed a commit that referenced this pull request Nov 5, 2019
Auto merge of #24521 - tigleym:missing_cssom_attributes, r=jdm
28dbbda 
Implement MouseEvent's x/y and offsetX/offsetY attributes

<!-- Please describe your changes on the following line: -->
Implement MouseEvent's x/y and offsetX/offsetY attributes

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #24248 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 28dbbda to master...

@bors-servo bors-servo merged commit 38b91c3 into servo:master Nov 5, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atouchet atouchet atouchet left review comments

@jdm jdm jdm requested changes

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing MouseEvent attributes defined by CSSOM View
7 participants
@tigleym @highfive @servo-wpt-sync @jdm @bors-servo @atouchet @asajeffrey