Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CGConfigureDisplayOrigin #343

Merged
merged 1 commit into from Oct 23, 2019
Merged

Add CGConfigureDisplayOrigin #343

merged 1 commit into from Oct 23, 2019

Conversation

zubivan
Copy link
Contributor

@zubivan zubivan commented Oct 22, 2019

Adds a wrapper for CGConfigureDisplayOrigin which has the following signature:

func CGConfigureDisplayOrigin(_ config: CGDisplayConfigRef?, 
                            _ display: CGDirectDisplayID, 
                            _ x: Int32, 
                            _ y: Int32) -> CGError

Please let me know if there is anything I can improve here.

I'm currently working on the small utility heavily relying on CoreGraphics API, so expect more of those to come as I go. :)

@zubivan
Copy link
Contributor Author

zubivan commented Oct 22, 2019

Got a flaky build on a previous run, cargo couldn't pull one of the crates due to a faulty network.
https://travis-ci.com/servo/core-foundation-rs/jobs/248481783#L143

@zubivan
Copy link
Contributor Author

zubivan commented Oct 23, 2019

Looks like there is a flaky test over here:
https://travis-ci.com/servo/core-foundation-rs/jobs/248484298#L410

@jdm
Copy link
Member

jdm commented Oct 23, 2019

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit 580e171 has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 580e171 with merge 12c15a5...

bors-servo pushed a commit that referenced this pull request Oct 23, 2019
Add CGConfigureDisplayOrigin

Adds a wrapper for [CGConfigureDisplayOrigin](https://developer.apple.com/documentation/coregraphics/1454090-cgconfiguredisplayorigin) which has the following signature:

``` c
func CGConfigureDisplayOrigin(_ config: CGDisplayConfigRef?,
                            _ display: CGDirectDisplayID,
                            _ x: Int32,
                            _ y: Int32) -> CGError
```

Please let me know if there is anything I can improve here.

I'm currently working on the small utility heavily relying on CoreGraphics API, so expect more of those to come as I go. :)
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 12c15a5 to master...

@bors-servo bors-servo merged commit 580e171 into servo:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants