Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcachefs: update 10 #71481

Merged
merged 4 commits into from Apr 6, 2020
Merged

bcachefs: update 10 #71481

merged 4 commits into from Apr 6, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from davidak and Chiiruno October 21, 2019 02:12
@davidak
Copy link
Member

davidak commented Oct 21, 2019

@eadwu can you specify the "Motivation for this change"? The last update is 4 days ago. Why is this needed? (i currently don't follow the development)

I opened a general discussion about how frequent unstable packages should be updated: https://discourse.nixos.org/t/how-frequent-to-update-unstable-packages/4458

Could you also build the changes and run the tests?

davidak
davidak approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(not tested)

@eadwu
Copy link
Member Author

eadwu commented Oct 21, 2019

There's no actual "motivation" to say, I namely just check the bcachefs-tool repository for updates before manually generating a patch for the kernel I wish to use it on (upstream uses 5.0) and since it's along the way, I just update the nix expressions as well. So for building, at least for the current revision, I've built it upon linux_latest and linux_testing. bcachefs-tools is rebuilt as I have it as a package in environment.systemPackages but since I don't explicitly build linux_testing_bcachefs I don't check the boxes.

Chiiruno
Chiiruno approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@Chiiruno Chiiruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works.

@ofborg ofborg bot requested review from davidak and Chiiruno November 6, 2019 02:13
@eadwu eadwu force-pushed the bcachefs/update-10 branch 4 times, most recently from 219e09f to 8f4fc75 Compare December 30, 2019 02:08
@Mic92 Mic92 merged commit a737f03 into NixOS:master Apr 6, 2020
@eadwu eadwu deleted the bcachefs/update-10 branch November 17, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak Awaiting requested review from davidak

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @davidak @Chiiruno @Mic92