Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions: update 2 #71482

Merged
merged 4 commits into from Oct 29, 2019
Merged

vscode-extensions: update 2 #71482

merged 4 commits into from Oct 29, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Oct 21, 2019

Simple bumps.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam merged commit 417df00 into NixOS:master Oct 29, 2019
@marsam
Copy link
Contributor

marsam commented Oct 29, 2019

Thank you!
btw, feel free to ping me if any PR gets stuck

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 29, 2019
@marsam @dtzWill
Merge pull request NixOS#71482 from eadwu/vscode-extensions/update-2
2ee3be8 
vscode-extensions: update 2
(cherry picked from commit 417df00)
@eadwu eadwu deleted the vscode-extensions/update-2 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @marsam