Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conftest: Remove sumdb override now that #34866 is merged #71479

Merged
merged 1 commit into from Oct 24, 2019
Merged

conftest: Remove sumdb override now that #34866 is merged #71479

merged 1 commit into from Oct 24, 2019

Conversation

c00w
Copy link
Contributor

@c00w c00w commented Oct 21, 2019

Motivation for this change

There was an override in place for conftest to disable the sumdb - with this change it is no longer needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from yurrriq and kalbasit October 21, 2019 01:17
yurrriq
yurrriq approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurrriq
Copy link
Member

yurrriq commented Oct 22, 2019

@GrahamcOfBorg build conftest

@kalbasit kalbasit merged commit 52c8d46 into NixOS:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c00w @yurrriq @kalbasit