Thank you for combining all the commits into a single PR :)

Do you mind rebasing this on top of the staging branch, then changing the base branch to staging. For large rebuilds we do this to avoid having people build against master get hit by large rebuilds

Do you mind rebasing this on top of the staging branch, then changing the base branch to staging. For large rebuilds we do this to avoid having people build against master get hit by large rebuilds

Ok, picked up the change requests from the individual PRs, rebased onto staging cleaned up the history. Feel free to close the individual PRs.

Thanks.

Feel free to close the individual PRs.

Could you do that yourself?

Could some please take the duty of running

nix-shell -p nix-review --run 'nix-review pr 71601

This includes building pretty much the whole Haskell ecosystem due to the extensive usage of Sphinx for documentation.

I expect quite a few builds to break as Sphinx has changed some defaults, e.g. the name of the documentation index page (contents.rst vs. index.rst) and not all packages may have that configured properly in their conf.py.

I will push this to a special branch soon where it will build on Hydra. It won't build everything but a lot.

I will push this to a special branch soon where it will build on Hydra. It won't build everything but a lot.

Thx.

rebased on current staging

ahh, I forgot to include sphinx itself when I cherry-picked the range. Sorry for that.

ahh, I forgot to include sphinx itself when I cherry-picked the range. Sorry for that.

Yep. But having sphinx in its own update isn't that bad, as it is the sphinx package itself which will trigger the mass rebuilds and probably break building of documentation for some packages.

Triggered a job at https://hydra.nixos.org/jobset/nixpkgs/python-unstable

This has landed in master so closing.