Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixODBCDrivers.msodbcsql17: add missing openssl dependency [19.09 backport] #71595

Merged
merged 1 commit into from Oct 22, 2019
Merged

unixODBCDrivers.msodbcsql17: add missing openssl dependency [19.09 backport] #71595

merged 1 commit into from Oct 22, 2019

Conversation

aanderse
Copy link
Member

(cherry picked from commit 18ad0a8)

Motivation for this change

#71573

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @spencerjanssen FYI

@aanderse aanderse added 0.kind: bug 8.has: port to stable A PR already has a backport to the stable release. labels Oct 21, 2019
@aanderse aanderse changed the title unixODBCDrivers.msodbcsql17: add missing openssl dependency unixODBCDrivers.msodbcsql17: add missing openssl dependency [19.09 backport] Oct 21, 2019
@ofborg ofborg bot requested a review from spencerjanssen October 21, 2019 23:47
@globin globin merged commit 88264b3 into NixOS:release-19.09 Oct 22, 2019
@aanderse aanderse deleted the msodbc branch October 22, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerjanssen spencerjanssen Awaiting requested review from spencerjanssen

Assignees
No one assigned
Labels
0.kind: bug 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @globin