Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sphinxcontrib-applehelp: init at 1.0.1 #71591

Closed
wants to merge 3 commits into from
Closed

pythonPackages.sphinxcontrib-applehelp: init at 1.0.1 #71591

wants to merge 3 commits into from

Conversation

wamserma
Copy link
Member

Motivation for this change

build dependency of sphinx 2.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@wamserma
pythonPackages.sphinxcontrib-applehelp: ini at 1.0.1
c90aff7 
build dep of sphinx 2.2.0

Commit-Beschreibung für Ihre Änderungen ein. Zeilen,
jonringer
jonringer reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions, otherwise LGTM

pkgs/development/python-modules/sphinxcontrib-applehelp/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sphinxcontrib-applehelp/default.nix Outdated Show resolved Hide resolved
@wamserma wamserma mentioned this pull request Oct 21, 2019
Closed
10 tasks
wamserma and others added 2 commits October 22, 2019 01:26
@wamserma @jonringer
Update pkgs/development/python-modules/sphinxcontrib-applehelp/defaul…
3b2c824 
…t.nix

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@wamserma @jonringer
Update pkgs/development/python-modules/sphinxcontrib-applehelp/defaul…
a37d4e6 
…t.nix

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@wamserma wamserma changed the base branch from master to staging October 22, 2019 07:18
@wamserma wamserma changed the base branch from staging to master October 22, 2019 07:23
@wamserma
Copy link
Member Author

superseded by #71601

@wamserma wamserma closed this Oct 22, 2019
@wamserma wamserma deleted the applehelp branch October 22, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @jonringer @Janik-Haag