Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinxcontrib-devhelp: init at 1.0.1 #71593

Closed
wants to merge 3 commits into from
Closed

Conversation

wamserma
Copy link
Member

Motivation for this change

build dependency of sphinx 2.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

build dep of sphinx 2.2.0
wamserma and others added 2 commits October 22, 2019 01:25
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@jonringer
Copy link
Contributor

since this is a part of #71601 , do you mind if i close all these smaller namespace pacakges and just track the issues in #71601

@wamserma
Copy link
Member Author

since this is a part of #71601 , do you mind if i close all these smaller namespace packages and just track the issues in #71601

whatever looks cleaner on git log - i reworked the commit messages for the individual PRs to fit the required format, so merging the individual PRs would be a bit more beautiful than doing it all in #71601

@jonringer
Copy link
Contributor

jonringer commented Oct 21, 2019

right, but none of them really have tests, but that's okay if sphinx exercises those code paths, its just that a series of fragmented PRs are a little harder to track, not to mention that they are all highly aligned to bumping sphinx

@wamserma
Copy link
Member Author

I deactivated the tests as they depend on sphinx. I'm pretty new to Nix, but in BitBake i would have made dependencies on the build stages on the packages (so sphinx would be built in between build of the sphinxcontrib-packages and test of the sphinxcontrib-packages). Any way to express this in Nix?

@jonringer
Copy link
Contributor

nix resolves the dependency graph into a direct-acyclic graph, so there's no way to have cycles. It's a known issue: #63168

@jonringer
Copy link
Contributor

jonringer commented Oct 21, 2019

you could technically do an override and pass whether or not you want the dependencies to test themselves, but AFAIK this is discouraged as you get a lot of one-off derivations

@wamserma
Copy link
Member Author

wamserma commented Oct 21, 2019

nix resolves the dependency graph into a direct-acyclic graph, so there's no way to have cycles. It's a known issue: #63168

Yes. That would need some way of snapshotting the derivations before running the tests, building sphinx and then running the tests from the snapshots. The derivations should not be influences by the test results. The important thing is that postponing the tests needs to be triggered by a nix expression so that the derivation does not change.

We should stop the off-topic discussions here.

@wamserma
Copy link
Member Author

superseded by #71601

@wamserma wamserma closed this Oct 22, 2019
@wamserma wamserma deleted the devhelp branch October 22, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants