-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sphinxcontrib-devhelp: init at 1.0.1 #71593
Conversation
build dep of sphinx 2.2.0
pkgs/development/python-modules/sphinxcontrib-devhelp/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/sphinxcontrib-devhelp/default.nix
Outdated
Show resolved
Hide resolved
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
whatever looks cleaner on git log - i reworked the commit messages for the individual PRs to fit the required format, so merging the individual PRs would be a bit more beautiful than doing it all in #71601 |
right, but none of them really have tests, but that's okay if sphinx exercises those code paths, its just that a series of fragmented PRs are a little harder to track, not to mention that they are all highly aligned to bumping sphinx |
I deactivated the tests as they depend on sphinx. I'm pretty new to Nix, but in BitBake i would have made dependencies on the build stages on the packages (so sphinx would be built in between build of the sphinxcontrib-packages and test of the sphinxcontrib-packages). Any way to express this in Nix? |
nix resolves the dependency graph into a direct-acyclic graph, so there's no way to have cycles. It's a known issue: #63168 |
you could technically do an override and pass whether or not you want the dependencies to test themselves, but AFAIK this is discouraged as you get a lot of one-off derivations |
Yes. That would need some way of snapshotting the derivations before running the tests, building sphinx and then running the tests from the snapshots. The derivations should not be influences by the test results. The important thing is that postponing the tests needs to be triggered by a nix expression so that the derivation does not change. We should stop the off-topic discussions here. |
superseded by #71601 |
Motivation for this change
build dependency of sphinx 2.2.0
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @