Skip to content
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.

Additional logind fixes #33

Merged
merged 4 commits into from Oct 21, 2019
Merged

Conversation

worldofpeace
Copy link

(cherry picked from commit 4b9e584)
The story is the same as in 471cffc:
device_attach() → seat_send_changed() → sd_bus_emit_properties_changed_strv()
→ emit_properties_changed_on_interface() → node_vtable_get_userdata()
→ seat_object_find(), which returns 0 because message == NULL.
But when we are emitting a signal, message is always NULL. Removing the
overeager check and assert in the called function allow the signal to be
emitted.

Fixes systemd#13769.

(cherry picked from commit 8cc64c2)
The same as parent commit, but users. This is the third and last
foo_object_find() function in logind, so I think that this particular
family of bugs is finally squashed.

(cherry picked from commit 8163b9f)
471cffc was committed on a debug VM where I
didn't have git set up properly.

(cherry picked from commit e48a1e3)
@worldofpeace worldofpeace changed the title Additonal logind fixes Additional logind fixes Oct 21, 2019
@Mic92 Mic92 merged commit d25cf41 into NixOS:nixos-v243 Oct 21, 2019
@worldofpeace worldofpeace deleted the logind-fixes branch October 21, 2019 21:32
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Oct 22, 2019
worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Oct 22, 2019
FRidh pushed a commit to NixOS/nixpkgs that referenced this pull request Oct 22, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants