libck: init at 0.7.0 #71518
Closed
libck: init at 0.7.0 #71518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lassulus
reviewed
Oct 23, 2019
Comment on lines
3
to
7
| let | ||
| version = "0.7.0"; | ||
| in stdenv.mkDerivation { | ||
| pname = "ck"; | ||
| inherit version; |
There was a problem hiding this comment.
this should be:
stdenv.mkDerivation rec {
pname = "ck";
version = "0.7.0";
Lassulus
reviewed
Oct 23, 2019
| homepage = "http://concurrencykit.org/"; | ||
| platforms = platforms.linux ++ platforms.darwin; | ||
| maintainers = with maintainers; [ chessai ]; | ||
| inherit version; |
jonringer
reviewed
Oct 23, 2019
| version = "0.7.0"; | ||
| in stdenv.mkDerivation { | ||
| pname = "ck"; | ||
| inherit version; |
There was a problem hiding this comment.
Suggested change
| inherit version; | |
| version = "0.7.0"; |
|
|
||
| let | ||
| version = "0.7.0"; | ||
| in stdenv.mkDerivation { |
There was a problem hiding this comment.
Suggested change
| in stdenv.mkDerivation { | |
| in stdenv.mkDerivation rec { |
| src = fetchFromGitHub { | ||
| owner = "concurrencykit"; | ||
| repo = "ck"; | ||
| rev = "refs/tags/${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "refs/tags/${version}"; | |
| rev = version; |
| homepage = "http://concurrencykit.org/"; | ||
| platforms = platforms.linux ++ platforms.darwin; | ||
| maintainers = with maintainers; [ chessai ]; | ||
| inherit version; |
There was a problem hiding this comment.
remove
Suggested change
| inherit version; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @chessai