Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxsmm: init at 1.13 #71498

Merged
merged 1 commit into from May 23, 2020
Merged

libxsmm: init at 1.13 #71498

merged 1 commit into from May 23, 2020

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai

@chessai chessai changed the title libxsmm: add libxsmm: init at 1.13 Oct 21, 2019
matthewbauer
matthewbauer reviewed Nov 7, 2019
View reviewed changes
pkgs/development/libraries/libxsmm/default.nix Outdated

installPhase = ''
runHook preInstall
make install SHELL=${bash}/bin/bash PREFIX=$out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use makeFlags = [ "PREFIX=$(out)" ]; instead of overriding installPhase to be more concise. SHELL is provided automatically.

@doronbehar
Copy link
Contributor

I'm closing as OP seems not intent to respond to review requests.

@doronbehar doronbehar closed this May 23, 2020
@chessai chessai reopened this May 23, 2020
@chessai
Copy link
Member Author

chessai commented May 23, 2020

@doronbehar thanks for the ping! responded to @matthewbauer's review

@matthewbauer matthewbauer merged commit 64f8baf into NixOS:master May 23, 2020
@chessai
Copy link
Member Author

chessai commented May 23, 2020

thanks @matthewbauer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chessai @doronbehar @matthewbauer