Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pifs: add #71504

Closed
wants to merge 1 commit into from
Closed

pifs: add #71504

wants to merge 1 commit into from

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai

c0bw3b
c0bw3b reviewed Oct 21, 2019
View reviewed changes
pkgs/tools/filesystems/pifs/default.nix
src = fetchFromGitHub {
owner = "philipl";
repo = "pifs";
rev = "3d9cc9db6a01234833c3d77c0846e20485763639";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's not version 1.0

c0bw3b
c0bw3b requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message doesn't follow nixpkgs guidelines.

More importantly, this package is a better candidate for NUR rather than nixpkgs

@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

Commit message doesn't follow nixpkgs guidelines.

More importantly, this package is a better candidate for NUR rather than nixpkgs

That point about NUR is accurate. I will close this then.

@chessai chessai closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chessai @c0bw3b