Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge: init at 1.0.4 #71486

Merged
merged 1 commit into from Oct 31, 2019
Merged

forge: init at 1.0.4 #71486

merged 1 commit into from Oct 31, 2019

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai

@chessai chessai force-pushed the forge-add branch 2 times, most recently from 3837de8 to b8647ef Compare October 21, 2019 05:28
c0bw3b
c0bw3b requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message and PR title

pkgs/development/libraries/forge/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/forge/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/forge/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/forge/default.nix Outdated Show resolved Hide resolved
@chessai chessai changed the title forge: add forge: init at 1.0.4 Oct 21, 2019
@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

applied all suggested changes and rebased

@chessai
Copy link
Member Author

chessai commented Oct 29, 2019

remaining suggested changes added, rebased

c0bw3b
c0bw3b approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71486 1

1 package were build:
  • forge

@c0bw3b c0bw3b merged commit ccae78c into NixOS:master Oct 31, 2019
@chessai
Copy link
Member Author

chessai commented Oct 31, 2019

thanks @c0bw3b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chessai @c0bw3b