Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmymoney: 5.0.5 -> 5.0.7 #71477

Merged
merged 1 commit into from Oct 23, 2019
Merged

kmymoney: 5.0.5 -> 5.0.7 #71477

merged 1 commit into from Oct 23, 2019

Conversation

das-g
Copy link
Member

@das-g das-g commented Oct 21, 2019 •
edited

and mark as not broken anymore

see PR #69616 for the corresponding change on master

Motivation for this change

Make the package build again, and available again on NixOS 19.09. (It was building and available on NixOS 19.03. In #68361 for NixOS 19.09 it was marked as broken due to not building.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested execution of ./result/bin/kmymoney
      → works fine
    • Tested execution of ./result/bin/.kmymoney-wrapped
      (no idea how to do that - running it naïvely results in an error: qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in "")
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

(There seem to be none for this package ...)

@das-g
kmymoney: 5.0.5 -> 5.0.7
5383748 
and mark as not broken anymore

see PR NixOS#69616 for the corresponding change on master
@globin globin merged commit 6639362 into NixOS:release-19.09 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@das-g @globin