Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.jsonlines: init at 1.2.0 #71705

Merged
merged 1 commit into from Nov 11, 2019
Merged

pythonPackage.jsonlines: init at 1.2.0 #71705

merged 1 commit into from Nov 11, 2019

Conversation

sondr3
Copy link
Contributor

@sondr3 sondr3 commented Oct 22, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox is for emulating different interpreters, nix already parameterizes this.

pkgs/development/python-modules/jsonlines/default.nix Outdated Show resolved Hide resolved
@sondr3 sondr3 force-pushed the python-package/jsonlines-init branch 3 times, most recently from 186d001 to 0822a53 Compare October 22, 2019 20:48
jonringer
jonringer approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (python38Packages.pytest is broken on master)
diff LGTM
tests run

[4 built (1 failed), 105 copied (47.0 MiB), 13.8 MiB DL]
error: build of '/nix/store/57d9l07s5yks5anwr9w4nxd859cb8crm-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71705
1 package failed to build:
python38Packages.jsonlines

2 package were build:
python27Packages.jsonlines python37Packages.jsonlines

pkgs/development/python-modules/jsonlines/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/jsonlines/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

please cleanup tox, and then it LGTM

@sondr3 sondr3 force-pushed the python-package/jsonlines-init branch from 0822a53 to 415ebe8 Compare October 22, 2019 21:55
@sondr3
Copy link
Contributor Author

sondr3 commented Oct 22, 2019

Done 😃

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.jsonlines python37Packages.jsonlines

@sondr3
Copy link
Contributor Author

sondr3 commented Nov 11, 2019

ping @jonringer 😅

@jonringer jonringer merged commit 150f62b into NixOS:master Nov 11, 2019
@sondr3 sondr3 deleted the python-package/jsonlines-init branch November 12, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sondr3 @jonringer