Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: 0.9.5 -> 0.10.0 #71699

Merged
merged 2 commits into from Oct 24, 2019
Merged

nomad: 0.9.5 -> 0.10.0 #71699

merged 2 commits into from Oct 24, 2019

Conversation

endocrimes
Copy link
Member

Motivation for this change

Updates Nomad to the recently released 0.10, and also adds myself as a maintainer after handling many of the recent Nomad releases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [na] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rushmorem @pradeepchhetri

@endocrimes
nomad: 0.9.5 -> 0.10.0
e1d0e62 
This commit upgrades Nomad from 0.9.5 to 0.10.0 and also pins the Golang
version to go1.12 as it is the only supported compiler for the current
release, and due to some dependency issues currently does not support
go1.13.
@endocrimes
nomad: add endocrimes as maintainer
cf1b585
jonringer
jonringer approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71699
1 package were build:
nomad

@jonringer jonringer merged commit f8d639b into NixOS:master Oct 24, 2019
@endocrimes endocrimes deleted the dani/nomad-0.10 branch October 24, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endocrimes @jonringer