Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] pythonPackages.lxml: 4.3.3 -> 4.4.1, reduce closure size #71553

Merged
merged 1 commit into from Oct 22, 2019
Merged

[staging] pythonPackages.lxml: 4.3.3 -> 4.4.1, reduce closure size #71553

merged 1 commit into from Oct 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 21, 2019 •
edited

Motivation for this change

was reducing the closure size and noticed it was out of date.

Looks like the dependencies were being passed through propagatedBuildInputs, which was causing a large closure bloat.

$ nix path-info -Sh ./result
/nix/store/mmfq7029d9ziawpl02grxz4jjfrklhwn-python3.7-lxml-4.3.3         160.5M
$ nix path-info -Sh ./result
/nix/store/4ig7nll10z63liiwbyhcmsy9c8yizmfz-python3.7-lxml-4.4.1         103.1M

roughly a 57MB savings :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

EDIT: and add myself as maintainer

@jonringer jonringer requested a review from FRidh as a code owner October 21, 2019 16:03
@FRidh
Copy link
Member

FRidh commented Oct 21, 2019

That's a really big improvement!

@jonringer jonringer changed the base branch from master to staging October 21, 2019 16:35
@jonringer
Copy link
Contributor Author

sorry for request spam, had to change base, as this rebuilds >1000 packages

@jonringer jonringer changed the title pythonPackages.lxml: 4.3.3 -> 4.4.1, reduce closure size [staging] pythonPackages.lxml: 4.3.3 -> 4.4.1, reduce closure size Oct 21, 2019
@FRidh
Copy link
Member

FRidh commented Oct 21, 2019

hydra job https://hydra.nixos.org/eval/1549994

@jonringer
Copy link
Contributor Author

oh thanks, for kicking that off. Should I close this, and make a python-unstable -> staging PR, and just fix build errors in that PR?

@jonringer
pythonPackages.lxml: 4.3.3 -> 4.4.1
ee1d256 
reduce closure size by not propagating native dependencies
@jonringer
Copy link
Contributor Author

@FRidh other than some timeouts, it looks like it was able to eval without any regression, merge?

@FRidh FRidh merged commit e1b6b90 into NixOS:staging Oct 22, 2019
@jonringer jonringer deleted the bump-lxml branch October 22, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh