pythonPackages.apsw: 3.22.0-r1 -> 3.29.0-r1 + sqlite fix #71711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Oct 22, 2019
d-goldin
force-pushed
the
bump_apsw_for_sqlite
branch
from
de39d10
to
2f5e6c6
Compare
|
this package doesn't cause many rebuilds, you could probably rebase it on top of master, and change the base branch Also staging is a little broken right now due to my bash-completion bump 😄 |
Bumping version of apsw to be able to backport an upstream fix for SQLite >= 3.30.0 which fixes a failing test.
|
@jonringer: I didn't put it on staging because of rebuilding, but because I initially thought it would be a bit odd to fix an issue on master before it happens, since the sqlite bump is still on staging. But you're right, in the end it doesn't change much. |
d-goldin
force-pushed
the
bump_apsw_for_sqlite
branch
from
2f5e6c6
to
b108fc8
Compare
|
oh, didn't realize this was dependent on another fix. You'll have to wait for #71672 to land for me to test then :/ |
|
It is related to: #70593 - there is a brief discussion around sqlalchemy and apsw breakage upon sqlite 3.30 update. The sqlalchemy fix and the sqlite 3.30 bump are both on staging right now. This PR by itself shouldn't cause any breakage and operate just fine with older sqlite versions. |
ofborg
bot
added
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
jonringer
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (21 failures on master)
diff LGTM
no regressions
[42 built (9 failed), 721 copied (5320.5 MiB), 1681.9 MiB DL]
error: build of '/nix/store/paa8xfkv98ab2yyxxg2l3n31xy0gmddj-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71711
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.wireguard linuxPackages_hardkernel_latest.wireguard
21 package failed to build:
calibre cozy deepin.dde-file-manager deepin.deepin-terminal deepin.deepin-wm gitAndTools.git-annex-metadata-gui python27Packages.apsw python27Packages.peewee python37Packages.apsw python37Packages.git-annex-adapter python37Packages.peewee python38Packages.SQLAlchemy-ImageAttach python38Packages.alot python38Packages.apsw python38Packages.git-annex-adapter python38Packages.magic-wormhole python38Packages.magic-wormhole-transit-relay python38Packages.peewee python38Packages.pip2nix s3ql sqlite-web
121 package were build:
acpica-tools acpidump-all afew alot armadillo astroid bup conkeror-unwrapped coreboot-utils cpp-hocon deepin.dde-control-center deepin.deepin-image-viewer deepin.deepin-menu deepin.deepin-screenshot deepin.deepin-shortcut-viewer deepin.qt5dxcb-plugin deepin.qt5integration dropbox dropbox-cli dumb-init elmPackages.elm-format facter firefox-bin-unwrapped firefox-esr-68-unwrapped friture gdcm giac giac-with-xcas gitAndTools.gitAnnex gitRepo gitlab-runner gmailieer gmic gnome-keysign groonga haskellPackages.notmuch health-check html-xml-utils icingaweb2 imagemagick7 imagemagick7Big imagemagick7_light intel-media-driver ipe ipv6calc janet jmol joker josm kodelife ktlint leatherman liblockfile libmesode libplacebo libwhereami linuxPackages-libre.wireguard linuxPackages.wireguard linuxPackages_4_14.wireguard linuxPackages_4_4.wireguard linuxPackages_4_9.wireguard linuxPackages_5_2.wireguard linuxPackages_5_3.wireguard linuxPackages_hardened.wireguard linuxPackages_latest-libre.wireguard linuxPackages_latest_hardened.wireguard linuxPackages_latest_xen_dom0.wireguard linuxPackages_testing_bcachefs.wireguard linuxPackages_testing_hardened.wireguard linuxPackages_xen_dom0.wireguard lockfileProgs logcheck lsp-plugins lttng-tools magic-wormhole mate.caja-dropbox monkeysphere muchsync nauty neomutt notmuch notmuch-addrlookup notmuch-mutt openmolcas openxray paperless phpPackages-unit.phpcbf phpPackages-unit.phpcs php72Packages.phpcbf php72Packages.phpcs php73Packages-unit.phpcbf php73Packages-unit.phpcs phpPackages.phpcbf phpPackages.phpcs pipenv plex plexRaw polymake postgresqlPackages.pgroonga profanity pulseeffects python27Packages.SQLAlchemy-ImageAttach python27Packages.Wand python27Packages.notmuch python27Packages.pip2nix python37Packages.SQLAlchemy-ImageAttach python37Packages.Wand python37Packages.magic-wormhole-transit-relay python37Packages.notmuch python37Packages.pip2nix python38Packages.Wand python38Packages.notmuch racket racket-minimal texmaker tflint vapoursynth vapoursynth-editor vapoursynth-mvtools waon wireguard-tools
|
we should off merging this until sqlite 3.30 lands... |
|
otherwise LGTM |
|
@jonringer: Oh, good catch. Well, then it's where it belongs now. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bumping version of apsw to be able to backport an upstream fix for
SQLite >= 3.30.0 which fixes a failing test.
Proposing this for staging, as the sqlite bump and sqlalchemy fix are on it too.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @FRidh @dtzWill