Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: use sddm in plasma5 #71622

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 22, 2019

Motivation for this change

Slim is abandoned and won't work with wayland.
It's in our best interest to use the display-manager
that makes most sense for Plasma5, sddm.

We've already moved on from it being default in #30890
and the graphical.nix profile, which the virtualbox profile uses,
has sddm anyway.


It would also be a good idea, for 20.03, to decide if we want to remove slim entirely.

Additional context

What we have going on with "profiles" here is rather messy.
See #47256, currently the virtualbox appliance has a demo user with a default password, while we've added the nixos user.
I would resolve this but it seems like a hassle, and with #49821 they're now actually documented, which I believe wasn't the best decision because these profiles are working as nixos internals. So now they're like a public API, while being sub-optimal.
So for the foreseeable future I won't contribute a change consolidating this. I'd prefer to keep the installation configuration separate, and something the user cannot leverage publicly.
It already contains dangerous configuration

and manually documenting is tedious. Unlike options, there's no generated documentation from values and such. Having something like an mkProfile which has some of the benefits of options would be helpful. That and not having scattered imports.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

Slim is abandoned and won't work with wayland.
It's in our best interest to use the display-manager
that makes most sense for Plasma5, sddm.

We've already moved on from it being default in NixOS#30890
and the graphical.nix profile, which the virtualbox profile uses,
has sddm anyway.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 22, 2019
@worldofpeace worldofpeace requested a review from ttuegel November 9, 2019 21:34
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

@worldofpeace worldofpeace merged commit c9601a6 into NixOS:master Nov 11, 2019
@worldofpeace worldofpeace deleted the iso-no-slim branch November 11, 2019 20:46
@worldofpeace worldofpeace mentioned this pull request Nov 11, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants