installer: use sddm in plasma5 #71622
Merged
+10
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Slim is abandoned and won't work with wayland.
It's in our best interest to use the display-manager
that makes most sense for Plasma5, sddm.
We've already moved on from it being default in #30890
and the graphical.nix profile, which the virtualbox profile uses,
has sddm anyway.
It would also be a good idea, for 20.03, to decide if we want to remove slim entirely.
Additional context
What we have going on with "profiles" here is rather messy.
See #47256, currently the virtualbox appliance has a
demo
user with a default password, while we've added thenixos
user.I would resolve this but it seems like a hassle, and with #49821 they're now actually documented, which I believe wasn't the best decision because these profiles are working as nixos internals. So now they're like a public API, while being sub-optimal.
So for the foreseeable future I won't contribute a change consolidating this. I'd prefer to keep the installation configuration separate, and something the user cannot leverage publicly.
It already contains dangerous configuration
and manually documenting is tedious. Unlike options, there's no generated documentation from values and such. Having something like an
mkProfile
which has some of the benefits of options would be helpful. That and not having scatteredimports
.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @