Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clfft: init at 2.12.2 #71494

Merged
merged 1 commit into from Oct 21, 2019
Merged

clfft: init at 2.12.2 #71494

merged 1 commit into from Oct 21, 2019

Conversation

chessai
Copy link
Member

@chessai chessai commented Oct 21, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @chessai

c0bw3b
c0bw3b reviewed Oct 21, 2019
View reviewed changes
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/clFFT/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
c0bw3b
c0bw3b requested changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also rework your commit message and PR title to
clfft; init at 2.12.2 clfft: init at 2.12.2

https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches

@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

applied all changes and rebased with proper commit message (clfft; init at 2.12.2)

@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

most recent suggestions completed

@chessai chessai changed the title clFFT: add clfft; init at 2.12.2 Oct 21, 2019
@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

changed PR title to comply with nixpkgs manual

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2019

@GrahamcOfBorg build clfft

c0bw3b
c0bw3b reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon me I misled you with a typo in my previous review. Commit message should be clfft: init at 2.12.2
With a colon, not a semi-colon... sorry >;<

pkgs/development/libraries/clfft/default.nix Show resolved Hide resolved
pkgs/development/libraries/clfft/default.nix Outdated Show resolved Hide resolved
@chessai chessai changed the title clfft; init at 2.12.2 clfft: init at 2.12.2 Oct 21, 2019
@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

Pardon me I misled you with a typo in my previous review. Commit message should be clfft: init at 2.12.2
With a colon, not a semi-colon... sorry >;<

I thought so, but didn't feel like mentioning it. I'll fix it.

@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

suggested changes applied. commit message revised for compliance.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2019

Thanks, I'll wait for the bot eval then retry the build

@chessai
Copy link
Member Author

chessai commented Oct 21, 2019

okay, and thank you so much for taking the time to review @c0bw3b

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2019

@GrahamcOfBorg build clfft

c0bw3b
c0bw3b approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71494 1

1 package were build:
  • clfft

@c0bw3b c0bw3b merged commit 9f4d260 into NixOS:master Oct 21, 2019
@chessai
Copy link
Member Author

chessai commented Oct 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chessai @c0bw3b