Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages: elm-format GHC 8.8.1 patch #71583

Merged
merged 1 commit into from Oct 22, 2019
Merged

elmPackages: elm-format GHC 8.8.1 patch #71583

merged 1 commit into from Oct 22, 2019

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 21, 2019 •
edited

Add back elm-format removed in #71538.
upstream PR: avh4/elm-format#640

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @avh4

@turboMaCk turboMaCk mentioned this pull request Oct 21, 2019
Closed
turboMaCk
turboMaCk commented Oct 21, 2019
View reviewed changes
pkgs/development/haskell-modules/configuration-hackage2nix.yaml
@@ -6322,7 +6322,6 @@ broken-packages:
- incremental-computing
- incremental-maps
- increments
- indents
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unmark indets as broken as this package seems to be working correctly now. Unfortunetely we still can't use it with elm-format.

This can be excluded from the PR.

@turboMaCk turboMaCk marked this pull request as ready for review October 21, 2019 21:07
@turboMaCk turboMaCk force-pushed the elm-format-ghc88x branch 2 times, most recently from 2352a0c to 54c6c48 Compare October 21, 2019 21:33
@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages.elm-format

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages.elm-format

1 similar comment
@domenkozar
Copy link
Member

@GrahamcOfBorg build elmPackages.elm-format

@domenkozar
Copy link
Member

Not sure what's up with darwin, but this works better than yesterday so I'm merging it.

@domenkozar domenkozar merged commit c1993e9 into NixOS:master Oct 22, 2019
@turboMaCk
Copy link
Member Author

turboMaCk commented Oct 22, 2019 •
edited

@domenkozar I have an older macbook as well. I'll try it on that machine later just for that feeling that it's still useful for something to me.

@turboMaCk
Copy link
Member Author

turboMaCk commented Oct 22, 2019 •
edited

It builds locally on darwin. Ofborg darwin build seems to be stucked though. Another unrelated build seems to be in the same state as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar domenkozar left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@turboMaCk @domenkozar