nixos/redis: Disable hugepages for redis via sysctl and not via a systemd-oneshot #71584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build nixosTests.nextcloud.with-postgresql-and-redis |
jtojnar
reviewed
Nov 6, 2019
| }; | ||
| boot.kernel.sysctl = { | ||
| "vm.nr_hugepages" = "0"; | ||
| } // mkIf cfg.vmOverCommit { "vm.overcommit_memory" = "1"; }; |
There was a problem hiding this comment.
Merging modules with // does not work and will need to be fixed using mkMerge like in #72916.
There was a problem hiding this comment.
Ah, I didn't know that. What is the explanation?
There was a problem hiding this comment.
Nix module system uses _type attributes to tag attribute sets:
nix-repl> lib.mkIf false { foo = 1; }
{ _type = "if"; condition = false; content = { ... }; }So if you merge it into a different attribute:
nix-repl> { bar = 5; } // lib.mkIf false { foo = 1; }
{ _type = "if"; bar = 5; condition = false; content = { ... }; }the bar will not be properly merged into content attribute, which the module attribute actually uses in the result.
We really need nixos-pills.
flokli
added a commit
to flokli/nixpkgs
that referenced
this pull request
Nov 8, 2019
NixOS#71584 did merging without mkMerge. cc @jtojnar
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 19, 2020
NixOS#71584 did merging without mkMerge. cc @jtojnar (cherry picked from commit 6303131)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #71414
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @flokli