Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pango: 1.43.0, backport CVE-2019-1010238 fix #71687

Merged
merged 1 commit into from Oct 29, 2019
Merged

pango: 1.43.0, backport CVE-2019-1010238 fix #71687

merged 1 commit into from Oct 29, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Oct 22, 2019 •
edited

Motivation for this change

There was a previous fix for this in
#71571

Addresses: #71571 (again)

But some things, most notably pygtk, still rely on deprecated pango
APIs that are not available past 1.43, this backports the CVE
fix to this version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c @jtojnar @worldofpeace

@d-goldin
pango: 1.43.0, backport CVE-2019-1010238 fix
9524bf3 
There was a previous fix for this in
NixOS#71571

But some things, most notably pygtk, still rely on deprecated pango
APIs that are not available past 1.43, this backports the CVE
fix to this version.
@d-goldin
Copy link
Contributor Author

Tested locally with inkscape, lilypond, pygtk and 1-2 small tools relying on pygtk, such as claws-mail.

@ofborg ofborg bot requested a review from 7c6f434c October 22, 2019 16:46
worldofpeace
worldofpeace approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be back-portable?

@d-goldin
Copy link
Contributor Author

Yeah, I think so.

@FRidh FRidh added this to Needs review in Staging (stable) Oct 24, 2019
@d-goldin
Copy link
Contributor Author

What are we missing review-wise on this one?

@7c6f434c 7c6f434c merged commit 298db02 into NixOS:master Oct 29, 2019
@eadwu
Copy link
Member

eadwu commented Oct 29, 2019

Getting a hash mismatch on the patch.

@d-goldin
Copy link
Contributor Author

d-goldin commented Oct 29, 2019 •
edited

@eadwu: Whoops. Thanks.

@d-goldin d-goldin mentioned this pull request Oct 29, 2019
Closed
10 tasks
@d-goldin d-goldin deleted the backport_cve_2019_1010238 branch October 29, 2019 13:59
d-goldin added a commit to d-goldin/nixpkgs that referenced this pull request Oct 29, 2019
@d-goldin
pango 1.43.0: Fixing wrong sha from NixOS#71687
ee13128
@FRidh FRidh moved this from Needs review to Merged in Staging (stable) Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@d-goldin @eadwu @7c6f434c @worldofpeace @veprbl