Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ba9b8f9d4ca6
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e10e7c1e27a4
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Oct 21, 2019

  1. Copy the full SHA
    494149b View commit details
  2. Tabs.

    pleroy committed Oct 21, 2019
    Copy the full SHA
    6c91c7e View commit details

Commits on Oct 22, 2019

  1. Merge pull request #2361 from pleroy/Clang

    A number of cleanups recommended by Clang
    pleroy authored Oct 22, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e10e7c1 View commit details
Showing with 10 additions and 5 deletions.
  1. +4 −0 Makefile
  2. +1 −1 journal/method_body.hpp
  3. +0 −2 numerics/fast_sin_cos_2π.cpp
  4. +1 −0 physics/massive_body_body.hpp
  5. +4 −2 physics/solar_system_body.hpp
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -79,6 +79,10 @@ SHARED_ARGS := \
-std=c++1z -stdlib=libc++ -O3 -g \
-fPIC -fexceptions -ferror-limit=1 -fno-omit-frame-pointer \
-Wall -Wpedantic \
-Wno-char-subscripts \
-Wno-gnu-anonymous-struct \
-Wno-nested-anon-types \
-Wno-unknown-pragmas \
-DPROJECT_DIR='std::filesystem::path("$(PROJECT_DIR)")' \
-DSOLUTION_DIR='std::filesystem::path("$(SOLUTION_DIR)")' \
-DTEMP_DIR='std::filesystem::path("/tmp")' \
2 changes: 1 addition & 1 deletion journal/method_body.hpp
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ typename P::Return Method<Profile>::Return(
returned_ = true;
if (Recorder::active_recorder_ != nullptr) {
return_filler_ =
[this, result](not_null<typename Profile::Message*> const message) {
[result](not_null<typename Profile::Message*> const message) {
Profile::Fill(result, message);
};
}
2 changes: 0 additions & 2 deletions numerics/fast_sin_cos_2π.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@

#pragma once

#include "numerics/fast_sin_cos_2π.hpp"

#include <pmmintrin.h>
1 change: 1 addition & 0 deletions physics/massive_body_body.hpp
Original file line number Diff line number Diff line change
@@ -141,6 +141,7 @@ inline not_null<std::unique_ptr<MassiveBody>> MassiveBody::ReadFromMessage(
if (enum_descriptor == google::protobuf::GetEnumDescriptor<Tag>()) {
switch (static_cast<Tag>(enum_value_descriptor->number())) {
ROTATING_BODY_TAG_VALUE_CASE(FRENET);
ROTATING_BODY_TAG_VALUE_CASE(PRINCIPAL_AXES);
}
}
}
6 changes: 4 additions & 2 deletions physics/solar_system_body.hpp
Original file line number Diff line number Diff line change
@@ -634,10 +634,12 @@ template<typename Frame>
template<typename Message>
void SolarSystem<Frame>::CheckFrame(Message const& message) {
if (message.has_solar_system_frame()) {
CHECK_EQ(Frame::tag, message.solar_system_frame());
CHECK_EQ(static_cast<int>(Frame::tag),
static_cast<int>(message.solar_system_frame()));
}
if (message.has_plugin_frame()) {
CHECK_EQ(Frame::tag, message.plugin_frame());
CHECK_EQ(static_cast<int>(Frame::tag),
static_cast<int>(message.plugin_frame()));
}
}