arrayfire-ml: init at 0.1.0 #71513
Closed
arrayfire-ml: init at 0.1.0 #71513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessai
force-pushed
the
arrayfire-ml-init
branch
from
215e6c2
to
395810e
Compare
|
version is 0.1.0 as per the cmakefile.txt |
Lassulus
requested changes
Oct 23, 2019
chessai
force-pushed
the
arrayfire-ml-init
branch
from
616020f
to
ddbc037
Compare
|
@Lassulus all suggestions applied. Rebased. |
|
whupps, sorry for the delay, this now needs a rebase |
chessai
force-pushed
the
arrayfire-ml-init
branch
from
ddbc037
to
63686a7
Compare
|
rebased |
chessai
force-pushed
the
arrayfire-ml-init
branch
from
63686a7
to
7095a53
Compare
|
getting this error now: |
|
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
stale
bot
added
the
2.status: stale
SuperSandro2000
requested changes
Nov 29, 2020
| @@ -0,0 +1,42 @@ | |||
| { stdenv, fetchurl, fetchFromGitHub, cmake, pkgconfig, arrayfire }: | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchurl, fetchFromGitHub, cmake, pkgconfig, arrayfire }: | |
| { stdenv, fetchurl, fetchFromGitHub, cmake, pkg-config, arrayfire }: |
| src = fetchFromGitHub { | ||
| owner = "arrayfire"; | ||
| repo = "arrayfire-ml"; | ||
| rev = "fde97a5bf157936c8d904d0c857c6cb3275ee527"; |
Comment on lines
+14
to
+15
| enableParallelBuilding = true; | ||
|
|
There was a problem hiding this comment.
Suggested change
| enableParallelBuilding = true; |
|
|
||
| enableParallelBuilding = true; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ cmake pkgconfig ]; | |
| nativeBuildInputs = [ cmake pkg-config ]; |
Comment on lines
+21
to
+23
| mkdir -p $out/lib | ||
| mkdir -p $out/LICENSES | ||
| mkdir -p $out/share |
There was a problem hiding this comment.
Suggested change
| mkdir -p $out/lib | |
| mkdir -p $out/LICENSES | |
| mkdir -p $out/share | |
| mkdir -p $out/LICENSES $out/lib $out/share |
stale
bot
removed
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @chessai