Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elm 0.19.1 #71538

Merged
merged 1 commit into from Oct 21, 2019
Merged

Elm 0.19.1 #71538

merged 1 commit into from Oct 21, 2019

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Oct 21, 2019 •
edited

No description provided.

@domenkozar domenkozar mentioned this pull request Oct 21, 2019
Closed
10 tasks
@domenkozar domenkozar force-pushed the elm-19.1 branch 2 times, most recently from ff9fb25 to bc4953d Compare October 21, 2019 14:53
@domenkozar
Copy link
Member Author

Seems like Elm changed the cache directory structure agian. Could someone compile a project with 0.19.1 that's not nixos and show contents of tree ~/.elm?

@simonchatts
Copy link
Contributor

@domenkozar Here you go:

.elm
└── 0.19.1
    ├── packages
    │   ├── avh4
    │   │   └── elm-color
    │   │       └── 1.0.0
    │   │           ├── LICENSE
    │   │           ├── README.md
    │   │           ├── artifacts.dat
    │   │           ├── docs.json
    │   │           ├── elm.json
    │   │           └── src
    │   │               └── Color.elm
    │   ├── elm
    │   │   ├── browser
    │   │   │   └── 1.0.1
    │   │   │       ├── LICENSE
    │   │   │       ├── README.md
    │   │   │       ├── artifacts.dat
    │   │   │       ├── docs.json
    │   │   │       ├── elm.json
    │   │   │       └── src
    │   │   │           ├── Browser
    │   │   │           │   ├── AnimationManager.elm
    │   │   │           │   ├── Dom.elm
    │   │   │           │   ├── Events.elm
    │   │   │           │   └── Navigation.elm
    │   │   │           ├── Browser.elm
    │   │   │           ├── Debugger
    │   │   │           │   ├── Expando.elm
    │   │   │           │   ├── History.elm
    │   │   │           │   ├── Main.elm
    │   │   │           │   ├── Metadata.elm
    │   │   │           │   ├── Overlay.elm
    │   │   │           │   └── Report.elm
    │   │   │           └── Elm
    │   │   │               └── Kernel
    │   │   │                   ├── Browser.js
    │   │   │                   ├── Browser.server.js
    │   │   │                   └── Debugger.js
... skip a few ...
    │   ├── lock
    │   └── registry.dat
    └── repl
        └── history

So package -> packages is maybe significant.

@domenkozar domenkozar changed the title WIP elm-0.19.1 Elm 0.19.1 Oct 21, 2019
@domenkozar
Copy link
Member Author

@GrahamcOfBorg build elmPackages

@domenkozar
Copy link
Member Author

@GrahamcOfBorg build elmPackages

I've disabled elm-format since it doesn't compile on GHC 8.8 /cc @avh4

turboMaCk
turboMaCk reviewed Oct 21, 2019
View reviewed changes
pkgs/development/haskell-modules/configuration-ghc-8.8.x.nix
@@ -66,6 +66,7 @@ self: super: {
th-expand-syns = doJailbreak super.th-expand-syns;
# TODO: remove when upstream accepts https://github.com/snapframework/io-streams-haproxy/pull/17
io-streams-haproxy = doJailbreak super.io-streams-haproxy; # base >=4.5 && <4.13
snap-server = doJailbreak super.snap-server;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrianHicks this is the solution for snap issue we've talked about.

@turboMaCk
Copy link
Member

  • compiles on nixos
  • binary works

Thanks for doing this 🎉

@avh4
Copy link
Member

avh4 commented Oct 21, 2019

I've disabled elm-format since it doesn't compile on GHC 8.8

Is that because of some haskell dependency that's requiring an older ghc version?

@avh4
Copy link
Member

avh4 commented Oct 21, 2019

Is GHC 8.8 stable? There doesn't appear to be a stack lts snapshot for GHC 8.8 yet

@avh4
Copy link
Member

avh4 commented Oct 21, 2019

Is that because of some haskell dependency that's requiring an older ghc version?

  • ansi-terminal-0.10.1 from stack configuration does not match >=0.8.2 && <0.9 (latest matching version is 0.8.2)
  • json must match >=0.9.3 && <0.10, but the stack configuration has no specified version (latest matching version is 0.9.3)
  • optparse-applicative-0.15.1.0 from stack configuration does not match >=0.14.3.0 && <0.15 (latest matching version is 0.14.3.0)

@avh4
Copy link
Member

avh4 commented Oct 21, 2019

looks like https://hackage.haskell.org/package/json does not support base-4.14 (ghc 8.8) yet

@turboMaCk
Copy link
Member

turboMaCk commented Oct 21, 2019 •
edited

looks like https://hackage.haskell.org/package/json does not support base-4.14 (ghc 8.8) yet

@avh4 there is a patch within this very PR https://github.com/NixOS/nixpkgs/pull/71538/files#diff-619e3c6e5466f1bc8925c9b62778d871R113-R118

turboMaCk
turboMaCk reviewed Oct 21, 2019
View reviewed changes
pkgs/development/compilers/elm/packages/elmi-to-json.nix
license = stdenv.lib.licenses.bsd3;
maintainers = with stdenv.lib.maintainers; [ turbomack ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big deal but you can keep me there. We should maybe define this in override rather than in this file so it can be easily regenerated though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to treat those files as auto-generated, feel free to override the maintainers field in default.nix :)

@domenkozar
Copy link
Member Author

Is GHC 8.8 stable?

it was released 2 months ago, but the reason elm-format fails is due to MonadFail proposal that has been unveiling for a few releases.

@domenkozar
Copy link
Member Author

@GrahamcOfBorg build elmPackages

@domenkozar domenkozar merged commit 99f2e88 into master Oct 21, 2019
This was referenced Oct 21, 2019
Closed
Merged
turboMaCk added a commit to turboMaCk/elm-format that referenced this pull request Oct 21, 2019
@turboMaCk
use Monad.Fail for better forward compatibility
4f4abdc 
This will ensure compatibility with future versions of base
realted to: NixOS/nixpkgs#71538
@turboMaCk turboMaCk mentioned this pull request Oct 22, 2019
Merged
10 tasks
@grahamc grahamc deleted the elm-19.1 branch December 28, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk turboMaCk left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@domenkozar @simonchatts @turboMaCk @avh4