Skip to content
This repository has been archived by the owner on Aug 6, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/systemd
base: ccec67cab6c0
Choose a base ref
...
head repository: NixOS/systemd
compare: d25cf413c6bf
Choose a head ref
  • 4 commits
  • 6 files changed
  • 1 contributor

Commits on Oct 21, 2019

  1. logind: drop {} 

    (cherry picked from commit 4b9e584)
    @keszybz @Mic92
    keszybz authored and Mic92 committed Oct 21, 2019
    Copy the full SHA
    a19663f View commit details
    Browse the repository at this point in the history

  2. logind: fix emission of PropertiesChanged on seats 

    The story is the same as in 471cffc:
device_attach() → seat_send_changed() → sd_bus_emit_properties_changed_strv()
→ emit_properties_changed_on_interface() → node_vtable_get_userdata()
→ seat_object_find(), which returns 0 because message == NULL.
But when we are emitting a signal, message is always NULL. Removing the
overeager check and assert in the called function allow the signal to be
emitted.

Fixes systemd#13769.

(cherry picked from commit 8cc64c2)
    @keszybz @Mic92
    keszybz authored and Mic92 committed Oct 21, 2019
    Copy the full SHA
    dde5856 View commit details
    Browse the repository at this point in the history

  3. logind: fix emission of PropertiesChanged for users 

    The same as parent commit, but users. This is the third and last
foo_object_find() function in logind, so I think that this particular
family of bugs is finally squashed.

(cherry picked from commit 8163b9f)
    @keszybz @Mic92
    keszybz authored and Mic92 committed Oct 21, 2019
    Copy the full SHA
    86f4b5c View commit details
    Browse the repository at this point in the history

  4. mailmap: add entry to fix authorship of commit 

    471cffc was committed on a debug VM where I
didn't have git set up properly.

(cherry picked from commit e48a1e3)
    @keszybz @Mic92
    keszybz authored and Mic92 committed Oct 21, 2019
    Copy the full SHA
    d25cf41 View commit details
    Browse the repository at this point in the history