Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elastix: 4.9.0 -> 5.0.0 (and mark unbroken) #71710

Merged
merged 1 commit into from Nov 18, 2019
Merged

elastix: 4.9.0 -> 5.0.0 (and mark unbroken) #71710

merged 1 commit into from Nov 18, 2019

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 22, 2019 •
edited

Motivation for this change

For ZHF (#68361).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Oct 24, 2019

@GrahamcOfBorg build elastix

c0bw3b
c0bw3b approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

Result of nix-review pr 71710 1

1 package were build:
  • elastix

@c0bw3b c0bw3b merged commit 5411dbd into NixOS:master Nov 18, 2019
@bcdarwin bcdarwin deleted the fix-elastix branch November 18, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @FRidh @c0bw3b