[backport] nixos-rebuild: support sudo + --target-host #71707
Closed
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
added
0.kind: enhancement
ofborg
bot
added
8.has: module (update)
|
Waiting for feedback / merge of #71849. |
I have `users.defaultUserShell = pkgs.fish;` set on my server and when I ran `nixos-rebuild switch --target-host …`, the command failed with the following error:
fish: Unsupported use of '='. To run 'nix-store' with a modified environment, please use 'env PATH=… nix-store…'
That is because fish requires env to set environment variables for a program. It should also work on other shells.
(cherry picked from commit 316d4fa)
This adds support for deploying to remote hosts without being root: sudo nixos-rebuild --target-host non-root@host Without this change, only root@host is able to deploy. The idea is that if the local command is run with sudo, so should the remote one, thus there is no need for adding any CLI options. (cherry picked from commit 263a81e)
Add --use-remote-sudo option. When set, remote commands will be prefixed with 'sudo'. This allows using sudo remotely _without_ having to use sudo locally (when using --build-host/--taget-host). (cherry picked from commit 2c09cfc)
bjornfor
force-pushed
the
backport-nixos-rebuild-sudo-target-host
branch
from
5d169e7 to
ef69202
Compare
|
#71849 was merged, please comment if this is OK or not to backport. |
|
Can you link PRs that this backports? Other than #71849 |
|
I don't know an easy way to do that. (But the commits are there, what do you need the PRs for?) Also, I think by now this PR is not going to be merged. (The new release is out already.) |
|
I was asking for PRs to double-check that they made it to a release/approved version (i.e. that they're not on some orphaned branch and so shouldn't make their way to a release). If you're ok with this not getting backported, then please close the PR. |
|
Github shows the branches that contain the commit (if any) just below the commit message. Or use 'git branch --contains COMMIT'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to use
nixos-rebuild --target-hostwith normal user and sudo instead of using root. Backport that feature from master branch to release-19.09. Also bring the related and dependent commit "nixos-rebuild: Fix target-host using fish".Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @