Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZminc: 2017-08-29 -> 2019-07-25; unbreak ezminc and pyezminc #71708

Merged
merged 2 commits into from Oct 26, 2019
Merged

EZminc: 2017-08-29 -> 2019-07-25; unbreak ezminc and pyezminc #71708

merged 2 commits into from Oct 26, 2019

Conversation

bcdarwin
Copy link
Member

Motivation for this change

Fix these packages for ZHF (#68361).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

please squash the commits

should just have one

pythonPackages.pyezminc: 2017-08-29 -> 2019-07-25

@bcdarwin
Copy link
Member Author

Only make a single commit for these two packages?

@jonringer
Copy link
Contributor

jonringer commented Oct 22, 2019 •
edited

correct, it will also be easier to cherry-pick if it's a single commit

@bcdarwin
Copy link
Member Author

@jonringer squashed

@jonringer
Copy link
Contributor

jonringer commented Oct 22, 2019 •
edited

please edit the commit subject to be : pythonPackages.pyezminc: 2017-08-29 -> 2019-07-25

@bcdarwin
Copy link
Member Author

But that's not the change that has been made (pyezminc's version wasn't changed).

@jonringer
Copy link
Contributor

oh wow, it looked like the same file to me when I was reviewing... So sorry, yes, please have 1 commit per package. you probably had it right the first time. I apologize

@bcdarwin
Copy link
Member Author

@jonringer -- done.

jonringer
jonringer approved these changes Oct 26, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work

[4 built, 3 copied (95.5 MiB), 13.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71708
2 package were build:
ezminc python27Packages.pyezminc

@jonringer jonringer merged commit 8d7fef4 into NixOS:master Oct 26, 2019
@bcdarwin bcdarwin deleted the update-ezminc branch October 26, 2019 17:18
@bcdarwin
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @jonringer