Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coq_8_10: enable CoqIDE #71664

Merged
merged 1 commit into from Oct 25, 2019
Merged

coq_8_10: enable CoqIDE #71664

merged 1 commit into from Oct 25, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 22, 2019

Motivation for this change

GTK3 has been fixed in master !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @roconnor @thoughtpolice @Zimmi48

@vbgl vbgl merged commit d56582e into NixOS:master Oct 25, 2019
@vbgl vbgl deleted the coq-enable-coqide branch October 25, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

@roconnor roconnor Awaiting requested review from roconnor

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Zimmi48