Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 872166e13650
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1230fc867443
Choose a head ref
  • 8 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 31, 2019

  1. Copy the full SHA
    a41af6a View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. lib/makeOverridable: Deduplicate override definition

    And call it overrideArgs in the let binding because that's what it does
    infinisil committed Sep 4, 2019
    Copy the full SHA
    a75080f View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e140d70 View commit details
    Browse the repository at this point in the history
  3. lib/makeOverridable: Propagate function arguments to override functions

    This allows querying the arguments you can .override:
    
      nix-repl> lib.functionArgs pkgs.hello.override
      { fetchurl = false; stdenv = false; }
    infinisil committed Sep 4, 2019
    Copy the full SHA
    d54bdf5 View commit details
    Browse the repository at this point in the history
  4. lib/makeOverridable: Propagate function args of the callPackage'd fun…

    …ction
    
    This allows querying function arguments of things like fetchFromGitHub:
    
      nix-repl> lib.functionArgs pkgs.fetchFromGitHub
      { fetchSubmodules = true; githubBase = true; ... }
    infinisil committed Sep 4, 2019
    Copy the full SHA
    c638dac View commit details
    Browse the repository at this point in the history
  5. lib/makeOverridable: Remove unimplemented overrideDerivation for func…

    …tions
    
    - Apparently nobody ever needed this
    - We already have enough ways to override things
    - Using overrideDerivation is discouraged
    infinisil committed Sep 4, 2019
    Copy the full SHA
    23e72ef View commit details
    Browse the repository at this point in the history
  6. lib/makeOverridable: Refactor

    - Rename ff to result because that's what it is
    - Better indentation
    - Less parens
    - Comment what overrideWith does
    infinisil committed Sep 4, 2019
    Copy the full SHA
    a4896cb View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Merge pull request #67809 from Infinisil/propagate-override-args

    lib.makeOverridable: Propagate function arguments
    infinisil committed Oct 22, 2019
    Copy the full SHA
    1230fc8 View commit details
    Browse the repository at this point in the history