dbus: enable building with musl #71560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build dbus pkgsMusl.dbus |
10 tasks
|
This is related to the following three PRs:
|
This was referenced Oct 21, 2019
nh2
approved these changes
Oct 22, 2019
When building dbus with musl, it must not take systemd as a buildInput, because systemd is not able to be build with musl.
cdepillabout
force-pushed
the
dbus-enable-building-with-musl
branch
from
b3e7779
to
7ada1d9
Compare
cdepillabout
commented
Oct 22, 2019
| @@ -3,6 +3,7 @@ | |||
| , fetchurl | |||
| , pkgconfig | |||
| , expat | |||
| , enableSystemd ? stdenv.isLinux && !stdenv.hostPlatform.isMusl | |||
| , systemd | |||
There was a problem hiding this comment.
Should I set systemd to systemd ? null as it is done for libusb1?
https://github.com/NixOS/nixpkgs/pull/71563/files#diff-81a3f0c1548ebc7ea522eb8c443aaa01R5
|
In 7ada1d9 I changed this to take an |
|
This has worked fine for me in static-haskell-nix so far, and no changes for non-musl; merging. |
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building dbus with musl, it must not take systemd as a buildInput, because systemd is not able to be built with musl.
Motivation for this change
This is from nh2/static-haskell-nix#50. In that issue, I was trying to get
vtebuilt usingpkgsMusl.vtetransitively depends ondbus, which can't be built with asystemddependency, sincesystemdcan't be compiled with musl.In order to check this you can run the following command:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/) they all seem to at least run somewhatnix path-info -Sbefore and after)Notify maintainers
cc @nh2 @domenkozar