Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch: 0.29.1 -> 0.29.2 #71677

Merged
merged 1 commit into from Oct 22, 2019
Merged

notmuch: 0.29.1 -> 0.29.2 #71677

merged 1 commit into from Oct 22, 2019

Conversation

puckipedia
Copy link
Contributor

Motivation for this change

Upstream updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from the-kenny and flokli October 22, 2019 15:00
jonringer
jonringer approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (1 broken on master)
diff LGTM
executable seems to work

[14 built (3 failed), 105 copied (2032.4 MiB), 209.0 MiB DL]
error: build of '/nix/store/8szm4c2zbwpfswrq98zbw2zymm46vg6a-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/71677
1 package failed to build:
python38Packages.alot

13 package were build:
afew alot astroid gmailieer haskellPackages.notmuch muchsync neomutt notmuch notmuch-addrlookup notmuch-mutt python27Packages.notmuch python37Packages.notmuch python38Packages.notmuch

@jonringer jonringer merged commit 27e7fcd into NixOS:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puckipedia @jonringer