unixODBCDrivers.msodbcsql17: add missing openssl dependency #71573
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Partial fix for #67594. It turns out that the
isql
tool provided by theunixODBC
package requiresopenssl
to be working withmsodbcsql17
. If you runldd
on thelibmsodbcsql17
.so
file from the old version compared to the new version (new and old defined by #67594) then you'll seeldd
no longer listsopenssl
, even thoughopenssl
is still required for theisql
tool to function. I'm not entirely sure about the details butopenssl
is listed as a dependency by microsoft andisql
fails withif
openssl
isn'tpatchelf
'd in... so this change is necessary.note:
isql
is broken in19.09
when usingmsodbcsql17
and this PR requires backport.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @spencerjanssen as an FYI