Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixODBCDrivers.msodbcsql17: add missing openssl dependency #71573

Merged
merged 1 commit into from Oct 21, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 21, 2019

Motivation for this change

Partial fix for #67594. It turns out that the isql tool provided by the unixODBC package requires openssl to be working with msodbcsql17. If you run ldd on the libmsodbcsql17 .so file from the old version compared to the new version (new and old defined by #67594) then you'll see ldd no longer lists openssl, even though openssl is still required for the isql tool to function. I'm not entirely sure about the details but openssl is listed as a dependency by microsoft and isql fails with

[08001][Microsoft][ODBC Driver 17 for SQL Server]SSL Provider: [OpenSSL library could not be loaded, make sure OpenSSL 1.0 or 1.1 is installed]
[08001][Microsoft][ODBC Driver 17 for SQL Server]Client unable to establish connection

if openssl isn't patchelf'd in... so this change is necessary.

note: isql is broken in 19.09 when using msodbcsql17 and this PR requires backport.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @spencerjanssen as an FYI

@aanderse aanderse merged commit 7defff8 into NixOS:master Oct 21, 2019
@aanderse
Copy link
Member Author

Will get a backport ready tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants