elmPackages.{elm-test,elm-analyse}: elm 0.19.1 updates #71693
Conversation
| @@ -3,7 +3,7 @@ | |||
| "elm-verify-examples", | |||
| "elm-doc-preview", | |||
| "elm-upgrade", | |||
| { "elm-analyse": "0.16.3" }, | |||
| "elm-analyse", | |||
There was a problem hiding this comment.
unblocked by update of nodePackages which which we share node-env.nix I believe
| @@ -5015,349 +5141,148 @@ in | |||
| elm-test = nodeEnv.buildNodePackage { | |||
| name = "elm-test"; | |||
| packageName = "elm-test"; | |||
| version = "0.19.0-rev6"; | |||
| version = "0.19.1"; | |||
There was a problem hiding this comment.
this is the most important update.
turboMaCk
changed the title
turboMaCk
force-pushed
the
elm-0.19.1-node-packages-updates
branch
from
f930530
to
ff88fe0
Compare
|
|
|
@GrahamcOfBorg build elmPackages |
|
be aware that elm-verify-examples still uses the old version of elm-test but this is not specific to nixpkgs - new version was not yet been release to npm either. |
|
I'm still getting 0.19.0-rev6 of elm-test - maybe I'm doing things wrong? It seems as if there is still some 0.19.0-rev6 mentioning in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/elm/packages/node-packages.nix#L1097-L1105 I'm a total beginner to nix packaging, so might be I'm misunderstanding something 😅 |
|
@valberg more likely you're using channel in which there is still old version. As I said above elm-verify-examples is still depending and using old version of elm test so the place you refer to is its dependecy I belive. This is a new elm-test https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/elm/packages/node-packages.nix#L5141-L5148. Make sure it's available in channel you're using https://github.com/NixOS/nixpkgs-channels |
Update elm node based packages after upgrade to 0.19.1 done in #71538
Changes:
elm-test 0.19.1 with elm 0.19.1 compatibility
elm-analyse 0.16.3 -> 0.16.4 upgrade possible since
node-env.nix(shared with nodePackages) was updatedTested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nix-review --run "nix-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
Notify maintainers
cc @domenkozar this is hopefully last one from my side for some time.