Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rand to 0.7 (fixes #24448) #24523

Merged
merged 2 commits into from Oct 23, 2019
Merged

Update rand to 0.7 (fixes #24448) #24523

merged 2 commits into from Oct 23, 2019

Conversation

nox
Copy link
Contributor

@nox nox commented Oct 22, 2019

No description provided.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/servoparser/prefetch.rs, components/webdriver_server/Cargo.toml, components/script/build.rs, components/constellation/Cargo.toml, components/script/Cargo.toml
  • @cbrewster: components/constellation/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @KiChjang: components/script/dom/servoparser/prefetch.rs, components/script/build.rs, components/script/Cargo.toml, components/net/Cargo.toml, components/net_traits/Cargo.toml
  • @emilio: components/style/stylesheets/rule_parser.rs, components/style/values/specified/length.rs, components/style/Cargo.toml, components/style/stylesheets/supports_rule.rs, components/style/values/specified/text.rs and 7 more

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 22, 2019
@SimonSapin
Copy link
Member

Your changes have decreased the stack size of commonly used DOM struct HTMLSpanElement from 400 to 368

Nice! Do you think the Option<Atom> layout optimization could contribute that much?

@jdm jdm added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 22, 2019
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 22, 2019
@nox
Copy link
Contributor Author

nox commented Oct 22, 2019

Nice! Do you think the Option<Atom> layout optimization could contribute that much?

Yep, seems like it, good idea.

@bors-servo r=jdm

@bors-servo
Copy link
Contributor

📌 Commit df14c5d has been approved by jdm

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 22, 2019
@nox
Copy link
Contributor Author

nox commented Oct 22, 2019

@bors-servo p=7

@bors-servo
Copy link
Contributor

⌛ Testing commit df14c5d with merge 7bcf126...

bors-servo pushed a commit that referenced this pull request Oct 22, 2019
Auto merge of #24523 - servo:rand, r=jdm
7bcf126 
Update rand to 0.7 (fixes #24448)
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 23, 2019
@CYBAI
Copy link
Member

CYBAI commented Oct 23, 2019

Failures in magicleap and android builds:

error[E0432]: unresolved import `xml5ever::rcdom`
  --> components/gfx/platform/freetype/android/font_list.rs:12:15
   |
12 | use xml5ever::rcdom::*;
   |               ^^^^^ could not find `rcdom` in `xml5ever`

error[E0432]: unresolved import `xml5ever::rcdom`
  --> components/gfx/platform/freetype/android/font_list.rs:13:15
   |
13 | use xml5ever::rcdom::{Node, RcDom};
   |               ^^^^^ could not find `rcdom` in `xml5ever`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:173:13
    |
173 |             NodeData::Element { ref name, .. } => &*name.local == "familyset",
    |             ^^^^^^^^ use of undeclared type or module `NodeData`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:190:17
    |
190 |                 NodeData::Element {
    |                 ^^^^^^^^ use of undeclared type or module `NodeData`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:280:17
    |
280 |                 NodeData::Element { ref name, .. } => &*name.local == "nameset",
    |                 ^^^^^^^^ use of undeclared type or module `NodeData`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:300:17
    |
300 |                 NodeData::Element {
    |                 ^^^^^^^^ use of undeclared type or module `NodeData`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:341:17
    |
341 |                 NodeData::Element { ref name, .. } => {
    |                 ^^^^^^^^ use of undeclared type or module `NodeData`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:440:17
    |
440 |                 NodeData::Text { ref contents } => {
    |                 ^^^^^^^^ use of undeclared type or module `NodeData`

error[E0433]: failed to resolve: use of undeclared type or module `NodeData`
   --> components/gfx/platform/freetype/android/font_list.rs:452:17
    |
452 |                 NodeData::Element { ref name, .. } => {
    |                 ^^^^^^^^ use of undeclared type or module `NodeData`

error: aborting due to 9 previous errors

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 23, 2019
@nox
Copy link
Contributor Author

nox commented Oct 23, 2019

Cherry-picked a commit by @SimonSapin which replaces the use of rcdom by xml-rs, which is already in our crate graph.

@bors-servo r=jdm,nox

@bors-servo
Copy link
Contributor

📌 Commit fc8cb63 has been approved by jdm,nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 23, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit fc8cb63 with merge 171035d...

bors-servo pushed a commit that referenced this pull request Oct 23, 2019
Auto merge of #24523 - servo:rand, r=jdm,nox
171035d 
Update rand to 0.7 (fixes #24448)
@SimonSapin SimonSapin mentioned this pull request Oct 23, 2019
Closed
@jdm
Copy link
Member

jdm commented Oct 23, 2019

Needs a mach fmt, unfortunately.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 23, 2019
@nox
Copy link
Contributor Author

nox commented Oct 23, 2019

Classic. Glad it happened in a way where your checklist wouldn't have reminded us. :P

@bors-servo r=jdm,nox

@bors-servo
Copy link
Contributor

📌 Commit 785a344 has been approved by jdm,nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 23, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 785a344 with merge 74d2560...

bors-servo pushed a commit that referenced this pull request Oct 23, 2019
Auto merge of #24523 - servo:rand, r=jdm,nox
74d2560 
Update rand to 0.7 (fixes #24448)
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 23, 2019
@nox
Copy link
Contributor Author

nox commented Oct 23, 2019

Grr.

@bors-servo retry #24369

@bors-servo
Copy link
Contributor

💣 Failed to start rebuilding: Unknown error

@bors-servo
Copy link
Contributor

⌛ Testing commit 785a344 with merge ddc7a37...

bors-servo pushed a commit that referenced this pull request Oct 23, 2019
Auto merge of #24523 - servo:rand, r=jdm,nox
ddc7a37 
Update rand to 0.7 (fixes #24448)
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 23, 2019
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm,nox
Pushing ddc7a37 to master...

@bors-servo bors-servo merged commit 785a344 into master Oct 23, 2019
@bors-servo bors-servo deleted the rand branch October 23, 2019 18:21
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nox @highfive @SimonSapin @bors-servo @CYBAI @jdm