Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: 3.28.0 backport fix for CVE-2019-16168 #71695

Merged
merged 1 commit into from
Nov 1, 2019
Merged

sqlite: 3.28.0 backport fix for CVE-2019-16168 #71695

merged 1 commit into from
Nov 1, 2019
+32 −0

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Oct 22, 2019 •
edited
Loading

Motivation for this change

This is a manually backported patch for a crash induced by a division by
zero. The patch had to be manually adopted to the "amalgamated" source
release.

Related: #70593
Addresses #68583 for 19.09

I'm suggesting this for 19.09 so that we don't have to bump versions.
Fix was manually verified using: https://www.sqlite.org/src/info/e4598ecbdd18bd82945f6029013296690e719a62

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

Sorry, something went wrong.

@d-goldin
sqlite: 3.28.0 backport fix for CVE-2019-16168
819ea59 
This is a manually backported patch for a crash induced by a division by
zero. The patch had to be manually adopted to the "amalgamated" source
release.
@ofborg ofborg bot requested review from np and edolstra October 22, 2019 17:47
@FRidh FRidh requested a review from andir October 23, 2019 07:24
@veprbl veprbl added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 24, 2019
@FRidh FRidh mentioned this pull request Oct 27, 2019
Closed
1 task
@d-goldin
Copy link
Contributor Author

@andir: What's your take on this?

@andir
Copy link
Member

andir commented Nov 1, 2019

Since people don't want the newer sqlite version on 19.09 I'll just merge this in. At least this topic will then be resolved.

@andir andir merged commit 02ad40a into NixOS:release-19.09 Nov 1, 2019
@d-goldin d-goldin deleted the backport_sqlite_fix branch November 1, 2019 11:00
@d-goldin
Copy link
Contributor Author

d-goldin commented Nov 1, 2019

@andir: Alright, thanks!

@veprbl veprbl mentioned this pull request Nov 7, 2019
Closed
@d-goldin d-goldin mentioned this pull request Nov 7, 2019
Merged
10 tasks
d-goldin added a commit to d-goldin/nixpkgs that referenced this pull request Nov 7, 2019
@d-goldin
sqlite-replication: fix build + CVE-2019-16168
3fe3061 
CVE fix in NixOS#71695 broke this package, as it's an older
version and additionaly disables amalgamation.

The supplied patch is modified minimally to fit this version (slight
line number change for analyze.c).

The fix was verified using
https://www.sqlite.org/src/info/e4598ecbdd18bd82945f6029013296690e719a62
as for the previous fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@np np

@edolstra edolstra

@andir andir

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-goldin @andir @veprbl