Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writers: fix writeC & tests #71586

Merged
merged 3 commits into from Oct 23, 2019
Merged

writers: fix writeC & tests #71586

merged 3 commits into from Oct 23, 2019

Conversation

Lassulus
Copy link
Member

Motivation for this change

finally fix writers.writeC

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Lassulus Lassulus changed the title Writers writers: fix writeC & tests Oct 22, 2019
@Lassulus Lassulus merged commit f417dd9 into NixOS:master Oct 23, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 23, 2019
@Lassulus @dtzWill
Merge pull request NixOS#71586 from Lassulus/writers
6f3ed50 
writers: fix writeC & tests
(cherry picked from commit f417dd9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4z3 4z3 4z3 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lassulus @4z3