Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manta: init 1.6.0 #75755

Merged
merged 1 commit into from Jan 24, 2020
Merged

manta: init 1.6.0 #75755

merged 1 commit into from Jan 24, 2020

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Dec 16, 2019

Motivation for this change

manta: init 1.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@aanderse
Copy link
Member

@jbedo I'd love to merge this... but after reading the description and github page I still have no idea what this software does 🤷‍♂️

Maybe if we call in some python experts like @FRidh and @jonringer they can review the package, ignoring anything about the software they don't know.

@jonringer
Copy link
Contributor

python2 is already EOL, I don't think we should be using it in any new expressions

@jonringer
Copy link
Contributor

@jonringer
Copy link
Contributor

I'm fine with this usage of python2, it's just for some python integration, and upstream is already aware that it's an issue

@jbedo jbedo force-pushed the manta branch 2 times, most recently from 5fb95fd to 507e75e Compare January 12, 2020 08:16
FRidh
FRidh previously requested changes Jan 12, 2020
pkgs/applications/science/biology/manta/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

jonringer commented Jan 24, 2020

would you need python at runtime? if so, we need to wrap the executable

        wrapProgram $out/bin/manta \
        --prefix PATH : "${python2}/bin"

the package needed is nativeBuildInputs = [ makeWrapper ];

@jbedo
Copy link
Contributor Author

jbedo commented Jan 24, 2020

All references to python end up as absolute paths after the fixup phase, so a wrapper ends up unnecessary.

@jonringer jonringer dismissed FRidh’s stale review January 24, 2020 09:42

Concerns addressed

@jonringer
Copy link
Contributor

@GrahamcOfBorg build manta

@jonringer jonringer merged commit 7f14226 into NixOS:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants