Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildah: 1.11.6 -> 1.12.0 #75632

Merged
merged 1 commit into from Dec 14, 2019
Merged

buildah: 1.11.6 -> 1.12.0 #75632

merged 1 commit into from Dec 14, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 14, 2019

Motivation for this change

Changelog: https://github.com/containers/buildah/releases/tag/v1.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable shows usage

[3 built, 13 copied (397.1 MiB), 99.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75632
1 package were built:
buildah

@jonringer jonringer merged commit d1913d1 into NixOS:master Dec 14, 2019
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executable shows usage

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75633
1 package were built:
fluent-bit

@jonringer
Copy link
Contributor

looks like i got my PRs mixed up, sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants