Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.python-twitter: init at 3.5 #75647

Merged
merged 1 commit into from Dec 15, 2019
Merged

pythonPackages.python-twitter: init at 3.5 #75647

merged 1 commit into from Dec 15, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 14, 2019

Motivation for this change

Add https://github.com/bear/python-twitter

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Dec 14, 2019

@GrahamcOfBorg build python3Packages.python-twitter

jonringer
jonringer approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[6 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75647
3 package were built:
python27Packages.python-twitter python37Packages.python-twitter python38Packages.python-twitter

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.python-twitter python37Packages.python-twitter python38Packages.python-twitter

@marsam marsam merged commit 1784ddb into NixOS:master Dec 15, 2019
@marsam marsam deleted the add-python-twitter branch December 15, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jonringer