Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bless: init at 0.6.2 #75670

Merged
merged 1 commit into from Feb 9, 2020
Merged

bless: init at 0.6.2 #75670

merged 1 commit into from Feb 9, 2020

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Dec 14, 2019 •
edited

Motivation for this change

Needed this for myself, might be useful for others, too

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mkg20001 mkg20001 mentioned this pull request Dec 14, 2019
Closed
@mkg20001
Copy link
Member Author

I've noticed this has several issues when running it on nixOS, didn't notice them at first because I had everything installed on my ubuntu machine.

Need to fix those first

jtojnar
jtojnar reviewed Dec 15, 2019
View reviewed changes
pkgs/applications/editors/bless/default.nix
# and it also wants to install that file
touch ./doc/user/bless-manual.omf

./autogen.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not preAutoreconf work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also need to invoke ./autogen.sh because the autoreconfHook calls the tools directly, but the script invokes some more tools that create necessary files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it seems to work that way, because the prefix is passed via configure phase

@jtojnar
Copy link
Contributor

jtojnar commented Dec 15, 2019

Ook, I was already looking forward to removing gtk-sharp.

Yeah, also getting some errors:

$ result/bin/bless 
result/bin/bless: line 3: mono: command not found
$ nix run -f '<nixpkgs>' mono -c result/bin/bless

Unhandled Exception:
System.TypeLoadException: Could not load type of field 'BlessMain:DataViewBox' (0) due to: Could not load file or assembly 'gtk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of its dependencies.
[ERROR] FATAL UNHANDLED EXCEPTION: System.TypeLoadException: Could not load type of field 'BlessMain:DataViewBox' (0) due to: Could not load file or assembly 'gtk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of its dependencies.

@mkg20001
Copy link
Member Author

Seems like it tries to search for it in $mono and $bless
Is there a way to add search paths via ENV to the list?

@mkg20001
Copy link
Member Author

It talks about LD_LIBRARY_PATH
Current attempts don't seem successful, possibly LD_PRELOAD should work

@mkg20001
Copy link
Member Author

It's fixed, please re-review

Br1ght0ne
Br1ght0ne approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review passes
executable works
NixOS unstable on x86_64

[3 built, 11 copied (332.9 MiB), 84.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75670
1 package built:
bless

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/88

@mkg20001
Copy link
Member Author

mkg20001 commented Feb 2, 2020

Applied review changes, should be good to merge now

@mkg20001
Copy link
Member Author

mkg20001 commented Feb 2, 2020

/me begs for a merge

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/94

@worldofpeace worldofpeace merged commit 4ced561 into NixOS:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mkg20001 @jtojnar @nixos-discourse @danieldk @Br1ght0ne @worldofpeace