Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nipype: fix build, add missing dependencies #75642

Merged
merged 2 commits into from Dec 16, 2019
Merged

python3Packages.nipype: fix build, add missing dependencies #75642

merged 2 commits into from Dec 16, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019 •
edited

Motivation for this change

noticed it was broken when reviewing a different PR a few days ago, got back around to fixing it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[5 built, 1 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75642
5 package were built:
python27Packages.etelemetry python27Packages.nipype python37Packages.etelemetry python37Packages.nipype python38Packages.etelemetry

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.etelemetry python27Packages.nipype python37Packages.etelemetry python37Packages.nipype python38Packages.etelemetry

@ofborg ofborg bot requested a review from ashgillman December 14, 2019 08:09
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.etelemetry python27Packages.nipype python37Packages.etelemetry python37Packages.nipype python38Packages.etelemetry

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.etelemetry python27Packages.nipype python37Packages.etelemetry python37Packages.nipype python38Packages.etelemetry

@jonringer jonringer merged commit a5097e9 into NixOS:master Dec 16, 2019
@jonringer jonringer deleted the fix-nipype branch December 16, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@ashgillman ashgillman Awaiting requested review from ashgillman

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer