Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dovecot: 2.3.8 -> 2.3.9.2 #75704

Merged
merged 1 commit into from Dec 15, 2019
Merged

dovecot: 2.3.8 -> 2.3.9.2 #75704

merged 1 commit into from Dec 15, 2019

Conversation

andir
Copy link
Member

@andir andir commented Dec 15, 2019

Motivation for this change

Update to latest version & updated the patch file to match with the
lastest verison.

Fixes the following security issue:

  • CVE-2019-19722: Mails with group addresses in From or To fields
    caused crash in push notification drivers.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@andir
dovecot: 2.3.8 -> 2.3.9.2
cd39434 
Update to latest version & updated the patch file to match with the
lastest verison.

Fixes the following security issue:
  * CVE-2019-19722: Mails with group addresses in From or To fields
    caused crash in push notification drivers.
@andir
Copy link
Member Author

andir commented Dec 15, 2019

@GrahamcOfBorg test dovecot

@andir andir mentioned this pull request Dec 15, 2019
Merged
10 tasks
@fpletz fpletz merged commit bbee883 into NixOS:master Dec 15, 2019
@andir andir deleted the dovecot branch December 16, 2019 09:15
@ghost
Copy link

ghost commented Dec 17, 2019

This broke dovecot_pigeonhole build and the simple-nixos-mailserver module with it.

@ghost ghost mentioned this pull request Dec 17, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@globin globin Awaiting requested review from globin

@peti peti Awaiting requested review from peti

@rickynils rickynils Awaiting requested review from rickynils

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @fpletz