Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port NixOS tests to python #75701

Merged
merged 10 commits into from Dec 18, 2019
Merged

Port NixOS tests to python #75701

merged 10 commits into from Dec 18, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Dec 15, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

tfc
tfc reviewed Dec 15, 2019
View reviewed changes
nixos/tests/paperless.nix Outdated Show resolved Hide resolved
tfc
tfc reviewed Dec 15, 2019
View reviewed changes
nixos/tests/quagga.nix Outdated Show resolved Hide resolved
@tfc tfc mentioned this pull request Dec 15, 2019
Closed
@veprbl
Copy link
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test systemd-timesyncd
@GrahamcOfBorg test switch-test
@GrahamcOfBorg test sonarr
@GrahamcOfBorg test quagga
@GrahamcOfBorg test postgis
@GrahamcOfBorg test php-pcre
@GrahamcOfBorg test pgmanage
@GrahamcOfBorg test peerflix
@GrahamcOfBorg test pdns-recursor
@GrahamcOfBorg test paperless

@veprbl
Copy link
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test switchTest

@veprbl veprbl merged commit 9faa37c into NixOS:master Dec 18, 2019
@kampka
Copy link
Contributor Author

kampka commented Dec 18, 2019

@veprbl @tfc Thanks for reviewing 👍

@kampka kampka deleted the port-tests-2 branch December 18, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc left review comments

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @veprbl @tfc