Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port NixOS tests to python #75703

Merged
merged 9 commits into from Dec 20, 2019
Merged

Port NixOS tests to python #75703

merged 9 commits into from Dec 20, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Dec 15, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@kampka kampka changed the title Port tests 3 Port NixOS tests to python Dec 15, 2019
@tfc tfc mentioned this pull request Dec 15, 2019
Closed
@veprbl
Copy link
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test overlayfs
@GrahamcOfBorg test osrm-backend
@GrahamcOfBorg test orangefs
@GrahamcOfBorg test nzbget
@GrahamcOfBorg test novacomd
@GrahamcOfBorg test nghttpx
@GrahamcOfBorg test nesting
@GrahamcOfBorg test mxisd
@GrahamcOfBorg test mutable-users

markuskowa
markuskowa approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orangefs part is OK.

@kampka
Copy link
Contributor Author

kampka commented Dec 20, 2019

@GrahamcOfBorg test mutableUsers

@kampka
Copy link
Contributor Author

kampka commented Dec 20, 2019

@veprbl Any objections to merging this?

veprbl
veprbl approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit aa934fa into NixOS:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @veprbl @markuskowa